emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 99d0244277 5/5: Don't test with proper-list-p in helm


From: ELPA Syncer
Subject: [nongnu] elpa/helm 99d0244277 5/5: Don't test with proper-list-p in helm-mklist (#2587)
Date: Fri, 10 Feb 2023 15:59:11 -0500 (EST)

branch: elpa/helm
commit 99d0244277f87b23944a828c5565d729b339d882
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Don't test with proper-list-p in helm-mklist (#2587)
    
    This is not supported in emacs-26 and break completely helm-mode.
---
 helm-lib.el | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/helm-lib.el b/helm-lib.el
index e3dbdd7982..7a3e893b46 100644
--- a/helm-lib.el
+++ b/helm-lib.el
@@ -242,14 +242,6 @@ available APPEND is ignored."
   (when (fboundp 'subr-native-elisp-p)
       (subr-native-elisp-p object)))
 
-;; Available only in emacs-27+
-(unless (fboundp 'proper-list-p)
-  (defun proper-list-p (seq)
-    "Return OBJECT's length if it is a proper list, nil otherwise."
-    (unless (or (null (consp seq))
-                (cdr (last seq)))
-      (length seq))))
-
 ;; Available only in Emacs-28+
 (unless (fboundp 'file-modes-number-to-symbolic)
   (defun file-modes-number-to-symbolic (mode &optional filetype)
@@ -734,9 +726,8 @@ See `helm-help-hkmap' for supported keys and functions."
 
 (defun helm-mklist (obj)
   "Return OBJ as a list.
-If OBJ is a proper list (but not lambda), return itself.
 Otherwise make a list with one element OBJ."
-  (if (and (listp obj) (proper-list-p obj) (not (functionp obj)))
+  (if (and (listp obj) (not (functionp obj)))
       obj
     (list obj)))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]