[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] scratch/hyperbole 5949c75121 13/15: (man-show): Fix miscompilatio
From: |
Stefan Monnier |
Subject: |
[elpa] scratch/hyperbole 5949c75121 13/15: (man-show): Fix miscompilation |
Date: |
Wed, 24 May 2023 10:06:17 -0400 (EDT) |
branch: scratch/hyperbole
commit 5949c75121368b44d7a16f8e74b0922796fe341f
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>
(man-show): Fix miscompilation
* hactypes.el (annot-bib): Avoid gratuitous `setq`.
(man-show): Declare `Man-notify-method` to fix miscompilation.
(rfc-toc): `select-buffer` doesn't exist.
---
hactypes.el | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/hactypes.el b/hactypes.el
index a622feb99e..0b10d978a3 100644
--- a/hactypes.el
+++ b/hactypes.el
@@ -32,14 +32,14 @@
;;; Standard Hyperbole action types
;;; ************************************************************************
-(defact annot-bib (key)
+(defact annot-bib (key) ;; FIXME: Clean up namespace use!
"Follow internal ref KEY within an annotated bibliography, delimiters=[]."
(interactive "sReference key (no []): ")
- (let ((key-regexp (concat "^[*]*[ \t]*\\[" (ebut:key-to-label key) "\\]"))
- citation)
- (if (save-excursion
- (goto-char (point-max))
- (setq citation (re-search-backward key-regexp nil t)))
+ (let* ((key-regexp (concat "^[*]*[ \t]*\\[" (ebut:key-to-label key) "\\]"))
+ (citation (save-excursion
+ (goto-char (point-max))
+ (re-search-backward key-regexp nil t))))
+ (if citation
(progn (hpath:display-buffer (current-buffer))
(goto-char citation)
(beginning-of-line))
@@ -688,6 +688,7 @@ package to display search results."
Uses `hpath:display-where' setting to control where the man page is displayed."
(interactive "sManual topic: ")
(require 'man)
+ (defvar Man-notify-method)
(let ((Man-notify-method 'meek))
(hpath:display-buffer (man topic))))
@@ -715,7 +716,7 @@ Optional SECTIONS-START limits toc entries to those after
that point."
(insert "Sections of " rfc-buf-name ":\n")
(set-buffer-modified-p nil))
(when opoint
- (select-buffer buf-name)
+ (set-buffer buf-name)
(goto-char opoint))))
(defact text-toc (section)
- [elpa] branch scratch/hyperbole created (now f47880579f), Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 4467b0a850 01/15: * hload-path.el (hyperb:dir): Use `macroexp-file-name`, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole b482b48c68 06/15: Fix compilation of test file, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 99519e4e98 11/15: * hycontrol.el (hycontrol-windows-mode-map): Don't autoload, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole e870f86331 12/15: * hui-select.el: Fix a few warnings and improve some docstrings, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole aa1562a614 14/15: Fix a few minor miscompilations and warnings, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole e126a76e8f 02/15: * hversion.el (hyperb:path-being-loaded): Delete function, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole b7e91d9f63 03/15: Try and avoid using `hyperb:stack-frame`, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 46d71b2228 09/15: * hyperbole.el: Preload `kotl-autoloads`, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 5949c75121 13/15: (man-show): Fix miscompilation,
Stefan Monnier <=
- [elpa] scratch/hyperbole d1a27a6853 05/15: Get rid of `hyperb:stack-frame`, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole f47880579f 15/15: * hyrolo.el: A few cosmetic tweaks, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 793e1a4254 04/15: (kotl-mode:pre-self-insert-command): Use buffer-locally at top-level, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 944dc22293 10/15: hyperbole-autoloads.el: Remove needless definitions, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 4d2cf095c0 07/15: (kview:char-visible-p): Delete function, Stefan Monnier, 2023/05/24
- [elpa] scratch/hyperbole 7d7ad7461f 08/15: * hact.el: Fix broken lexical-binding cookie, Stefan Monnier, 2023/05/24