emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org b5aaefb551 2/4: org-babel-variable-assignments:eshe


From: ELPA Syncer
Subject: [elpa] externals/org b5aaefb551 2/4: org-babel-variable-assignments:eshell: Prevent leaking values into results
Date: Sat, 12 Aug 2023 06:58:24 -0400 (EDT)

branch: externals/org
commit b5aaefb5517eba83ebe6fcde0d2fa580a9d1e449
Author: Ihor Radchenko <yantar92@posteo.net>
Commit: Ihor Radchenko <yantar92@posteo.net>

    org-babel-variable-assignments:eshell: Prevent leaking values into results
    
    * lisp/ob-eshell.el (org-babel-variable-assignments:eshell): Wrap
    `setq' eshell call into `ignore' to prevent the variable assignment
    values leaking into block output.  Fixes
    `ob-eshell/variables-assignment'.
---
 lisp/ob-eshell.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-eshell.el b/lisp/ob-eshell.el
index 95f5777ae7..fa19f874a2 100644
--- a/lisp/ob-eshell.el
+++ b/lisp/ob-eshell.el
@@ -97,7 +97,8 @@ The PARAMS are variables assignments."
   "Convert ob-eshell :var specified variables into Eshell variables 
assignments."
   (mapcar
    (lambda (pair)
-     (format "(setq %s %S)" (car pair) (cdr pair)))
+     ;; Use `ignore' to suppress value in the command output.
+     (format "(ignore (setq %s %S))" (car pair) (cdr pair)))
    (org-babel--get-vars params)))
 
 (defun org-babel-load-session:eshell (session body params)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]