emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/clojure-ts-mode a244ddeee3 43/71: Add comment to explain w


From: ELPA Syncer
Subject: [nongnu] elpa/clojure-ts-mode a244ddeee3 43/71: Add comment to explain why extracting seems over-complicated.
Date: Fri, 25 Aug 2023 03:59:35 -0400 (EDT)

branch: elpa/clojure-ts-mode
commit a244ddeee34c081149ae826767027db61a79ee81
Author: dannyfreeman <danny@dfreeman.email>
Commit: dannyfreeman <danny@dfreeman.email>

    Add comment to explain why extracting seems over-complicated.
    
    We don't want metadata included in definition names shown in imenu
---
 clojure-ts-mode.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el
index 47c063ae32..5ea7caecbb 100644
--- a/clojure-ts-mode.el
+++ b/clojure-ts-mode.el
@@ -406,6 +406,9 @@ Can be called directly, but intended for use as 
`treesit-defun-name-function'."
              (clojure-ts--symbol-node-p (treesit-node-child node 0 t)))
     (let ((sym (treesit-node-child node 1 t)))
       (when (clojure-ts--symbol-node-p sym)
+        ;; Extracts ns and name, and recreates the full var name.
+        ;; We can't just get the node-text of the full symbol because
+        ;; that could include metadata that isn't part of the name.
         (let ((ns (treesit-node-child-by-field-name sym "ns"))
               (name (treesit-node-child-by-field-name sym "name")))
           (if ns



reply via email to

[Prev in Thread] Current Thread [Next in Thread]