Re: Add support for TLS client certificates to 'erc-tls'

[J.P.]

Amin Bandali <bandali@gnu.org> writes:

> J.P. writes:
>
>> Amin Bandali <bandali@gnu.org> writes:
>>
>>>> It reconnected successfully with no hiccups, so I think that's one
>>>> for the win column.
>>
>> This continues to be the case with the latest changes applied; ditto
>> when using the authinfo variant of the new :client-certificate param.
>
> Great!

Um, eek! This one's on me, 100%.

Turns out my trial runs weren't as methodical or studied as I'd hoped,
and somewhere I decided that bouncing the connection instead of killing
it off completely was A-okay.

But trying again just now using a less foolish way (dropping PONGs via
firewall and waiting for the server to kill off the connection), I'm
finding the opposite to be true and that I'm *not* able to reconnect
successfully.

I guess one option would be to simply make `erc-server-reconnect' pass
`erc-session-client-certificate' to `erc-open'. That'd obviously work
because it would just reassign the value to the same variable.

To get even more roundabout, `erc-open' could delegate to
`erc-determine-parameters' for any reconciling that may need doing in
some imagined future. The supposed justification for this would be that
certs qualify as "connection and authentication" related, which
`erc-determine-parameters' says it's all about.

Anyway, guess I'll just hang on to the dunce cap from now on.