Re: bug#29108: 25.3; ERC SASL support

[Amin Bandali]

Hey J.P., (all,)

J.P. writes:

> v14. Revised docs a bit and renamed some compat functions. Added a 900
> handler to erc-backend. Added secrets-wrapping for auth-source-pass
> results in erc-compat. Ditched hook indirection for AUTHENTICATE
> handler.
>

Thanks!  I've pushed all of these patches.  All but one of them
were committed without any additional changes; and that one was
0006-Add-non-IRCv3-SASL-module-to-ERC.patch, where I just added
the missing entries for doc/misc/erc.texi and etc/ERC-NEWS to the
commit message.

> Subject: [PATCH 4/8] Support local ERC modules in erc-mode buffers
[...]
> diff --git a/doc/misc/erc.texi b/doc/misc/erc.texi
> index 0d807e323e..b9c6e33d36 100644
> --- a/doc/misc/erc.texi
> +++ b/doc/misc/erc.texi
> @@ -390,8 +390,11 @@ Modules
>  
>  There is a spiffy customize interface, which may be reached by typing
>  @kbd{M-x customize-option @key{RET} erc-modules @key{RET}}.
> -Alternatively, set @code{erc-modules} manually and then call
> -@code{erc-update-modules}.
> +When removing a module outside of the Custom ecosystem, you may wish
> +to ensure it's disabled by invoking its associated minor-mode toggle,
> +such as @kbd{M-x erc-spelling-mode @key{RET}}.  Note that, these days,
> +calling @code{erc-update-modules} in an init file is typically
> +unnecessary.

What do you think about tweaking the last sentence to be more specific
about when calling `erc-update-modules' may still be needed, maybe
with a short example, please?

> Subject: [PATCH 6/8] Add non-IRCv3 SASL module to ERC
[...]
> diff --git a/doc/misc/erc.texi b/doc/misc/erc.texi
[...]

What do you think about adding a few short examples to the manual
showing the usage of each of the variants/mechanisms with a call to
`erc-tls'?  Kind of like the ones in "Connecting to an IRC Server"
that show how to use `:client-certificate' for instance.

Many thanks for all of your work on implementing and landing SASL
support for ERC, a feature that many ERC users (myself included)
have wished for and looked forward to seeing in ERC for years!

-amin