Re: [Orgmode] Re: org-show-effort ideas

[Adam Spiers]

Benjamin Andresen (address@hidden) wrote:
> Adam Spiers <address@hidden> writes:
> 
> > I definitely did try it, and I just did another 'git pull' and tried
> > again, and I still don't see it, so I guess we're talking about
> > different things ;-)
> >
> > To clarify, I'm referring to showing effort via a single keystroke
> > when on a todo line in the *Org Agenda* buffer.  Currently, when I hit
> > "e" on a todo which has an existing "Effort" property value set, my
> > minibuffer prompt shows "Value: ".  The same applies with C-c C-x e in
> > a normal .org file buffer.
> 
> When I press 'e' in an agenda on an item that has the Effort property
> value set, I get a minibuffer prompt that shows "Value [5]: " when the
> Effort value is 5.
> 
> This is with a git version from Sunday morning.
> 
> Check the source of the function org-set-effort, it will show you that
> it concats "[" cur "]", where cur is the current Effort prop value.

Thanks for the pointer - it seems that the "[" cur "]" is only
included when

  (org-property-get-allowed-values nil prop 'table)

is nil - and in my case I have a global Effort_ALL property set which
means that this is never the case.  So I think this is a bug which can
be trivially fixed by assigning the prompt string in the let* variable
list, and then using it in both invocations of org-completing-read.