emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] Bug: org-habit and headlines with links


From: Carsten Dominik
Subject: Re: [Orgmode] Bug: org-habit and headlines with links
Date: Sun, 31 Jan 2010 17:54:53 +0100

I have applied this patch, thanks.

- Carsten

On Jan 31, 2010, at 5:46 PM, Luke Amdor wrote:

That fixed it. Thanks!

Luke


On Thu, Jan 28, 2010 at 11:32 AM, Carsten Dominik <address@hidden > wrote:
Hi Luke,

thanks for the bisect, that was useful.

Could you please try if the following patch does reliably fix this problem?

Thanks!!

- Carsten

diff --git a/lisp/org-habit.el b/lisp/org-habit.el
index cf53057..deb8132 100644
--- a/lisp/org-habit.el
+++ b/lisp/org-habit.el
@@ -305,7 +305,7 @@ current time."
 (defun org-habit-insert-consistency-graphs (&optional line)
  "Insert consistency graph for any habitual tasks."
  (let ((inhibit-read-only t) l c
-       (buffer-invisibility-spec nil)
+       (buffer-invisibility-spec '(org-link))
       (moment (time-subtract (current-time)
(list 0 (* 3600 org-extend-today- until) 0))))
    (save-excursion


On Jan 17, 2010, at 4:45 PM, Luke Amdor wrote:

When I have a headline with a link on it and I have that headline's habit property set to true, org-habit will barf all over my link when presenting the agenda. This will only happen when org-habit- graph-column is set something shorter than the full raw text of the link (which is about all of them).

I ran git bisect on org-mode and found the bad commit to be:

commit 2f5f6e401f187c2db8131cdbc4355b688ce4c55a
Author: Carsten Dominik <address@hidden>
Date:   Mon Jan 4 09:58:53 2010 +0100

   Turn off invisibility while constructing habit graphs

   Bernt Hansen reported strange things happening to the display when
   graph tasks are hidden while updating a task in the agenda.

Here's my bisect log:

# bad: [0e370d498b34469a025cdce864fd5c5987bf8050] Fix typo
# good: [a7fb89e9edf59f50294199046e570b4b11bb13b1] Merge branch 'master' of git+ssh://repo.or.cz/srv/git/org-mode
git bisect start 'origin/master' 'HEAD'
# good: [21ad7f0bef20addfe15fbe3e95d65e6c810d68f1] Fix typo
git bisect good 21ad7f0bef20addfe15fbe3e95d65e6c810d68f1
# good: [0b5d9bf1c62454523b275dd6a6b95bf881580eb1] Merge branch 'org- ctags'
git bisect good 0b5d9bf1c62454523b275dd6a6b95bf881580eb1
# bad: [588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9] org-exp- generic.el: Fix bug with closing bodies
git bisect bad 588a42d4fd2e59e3f69d5a3f9ea00ff3a64f5df9
# bad: [32441cd15150f541d3ba50633cfb9fffc8d3d11a] Fix agenda link opening bug
git bisect bad 32441cd15150f541d3ba50633cfb9fffc8d3d11a
# bad: [ddcb2be1c8920fabfbca3777cc774ed1ac653a6e] Work-around for formatting bug with email subject line from wanderlust
git bisect bad ddcb2be1c8920fabfbca3777cc774ed1ac653a6e
# good: [c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710] Make C-c r C customize remember templates
git bisect good c23ade5d8e4b3cd4f0c4dbe5260cad1f227d2710
# good: [f266ee62bb8282cc883adea9f26362b2d3b1ab7d] Fix typo
git bisect good f266ee62bb8282cc883adea9f26362b2d3b1ab7d
# bad: [2f5f6e401f187c2db8131cdbc4355b688ce4c55a] Turn off invisibility while constructing habit graphs
git bisect bad 2f5f6e401f187c2db8131cdbc4355b688ce4c55a

Luke
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
address@hidden
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten





- Carsten







reply via email to

[Prev in Thread] Current Thread [Next in Thread]