emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] org-html link building diff


From: Tom Breton (Tehom)
Subject: Re: [Orgmode] org-html link building diff
Date: Tue, 27 Apr 2010 23:01:18 -0400
User-agent: SquirrelMail/1.4.19

The changes are essentially made and pass my tests now, there's mostly
housekeeping now: pull, merge, push.

> Yes.  Send me your name on repo.or.cz and I'll add push for you.
> Please create your own branch and stay on it.

It is "Tehom".

> This is for having a clickable Thumbnail - I am not sure if this is
> also handled elsewhere.

I believe it is.  The only difference seems to be that the first
builds:

 : <a href="foo/target.html"><img src="some.jpg"></a>

all by itself and the second builds:

 : <img src="some.jpg" href="foo/target.html">

thru `org-export-html-format-image'.  Only the second handles
captions.  If the captions etc are the issue, then it should all go
thru the second.  Plus, `org-export-html-format-image' seems to be the
right place for image code.  It would be bad if changes added to
`org-export-html-format-image' didn't take because this other code
handled it instead.

A few questions:

 * Encountered while writing tests: When type is file and path is an
   absolute filename, we do substitutions.  Like "/foo/unfoo/.././baz"
   becomes "/foo/baz".  But we don't do them when path is relative.
   Why not?

   Is that just because we'd then need to make it relative again which
   is more code, or is there some other reason?

 * Also found in the course of testing: "id:" links cause errors when
   buffer is not associated with a file.  This can happen when the arg
   body-only is passed.

   * Punt id links in that case?

   * Do them but avoid the filename relativizing step?

 * How do you feel about url-parse?  It's bundled with emacs, builds
   and destructures urls.  IMO we're not at the stage where it
   provides more help than the extra work it requires yet.

        Tom Breton (Tehom)






reply via email to

[Prev in Thread] Current Thread [Next in Thread]