Re: [Orgmode] Two bugs in org-indent (plus a fix to correct one of them)

[William Henney]

Hi David

Thanks for looking at this.

On Tue, Jun 15, 2010 at 6:02 AM, David Maus <address@hidden> wrote:
> William Henney wrote:
>>Hi all
>
>>1. If one sets org-indent-indentation-per-level to any value other
>>than the default of 2, then the indentation of lines following a
>>heading is not correct. I seem to have managed to fix this by changing
>>line 231 of org-indent.el from
>
>>                n (* (or level 0) org-indent-indentation-per-level))))))))
>
>>to
>
>>                n (+ 2 (* (1- (or level 0)) 
>> org-indent-indentation-per-level)))))))))
>
>>Tested with org-indent-indentation-per-level = 0, 1, 2, and 3.
>
> I don't understand this: The original formula sets the indentation
> level of n times org-indent-indentation-per-level with n being the
> outline level.  Why do you consider this not being correct?[1]
>

Consider what one would want to happen when
org-indent-indentation-per-level = 1 (which is what I prefer):

Indentation of 0
* Level one heading
  Indentation of 2
** Level two heading
   Indentation of 3
*** Level three heading
    Indentation of 4

So, the desired sequence of indentation is [0, 2, 3, 4, ...] whereas
the original formula gives the sequence [0, 1, 2, 3, ...]

> [1] Besides, the suggested function does not consider no outline
> level.  I.e. returns negative indentation.

Yes, you are quite right -- my function does indeed return garbage if
you are before the first headline.  However, in practice this is not a
problem since the line-prefix and wrap-prefix text properties only
seem to get applied to text after headlines. But I am sure that the
lisp experts on the list can come up with a more elegant function than
mine.

Cheers

Will


-- 

  Dr William Henney, Centro de Radioastronomía y Astrofísica,
  Universidad Nacional Autónoma de México, Campus Morelia