Re: [Orgmode] [PATCH] Use backquotes to make byte compiler expand `flet' macro.

[Carsten Dominik]

Hi David,

this is a great solution, thanks.

- Carsten

On Jun 27, 2010, at 6:01 PM, David Maus wrote:

> * org-agenda.el (org-write-agenda): Use backquotes to expand
> `flet' at compile time.
> ---
> lisp/org-agenda.el |   12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 8035add..9056206 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -2450,7 +2450,7 @@ higher priority settings."
>    ((string-match "\\.html?\\'" file) (require 'htmlize))
>    ((string-match "\\.ps\\'" file) (require 'ps-print)))
>   (org-let (if nosettings nil org-agenda-exporter-settings)
> -    '(save-excursion
> +    `(save-excursion
>        (save-window-excursion
>          (org-agenda-mark-filtered-text)
>          (let ((bs (copy-sequence (buffer-string))) beg)
> @@ -2482,14 +2482,14 @@ higher priority settings."
>                (message "HTML written to %s" file))
>               ((string-match "\\.ps\\'" file)
>                (require 'ps-print)
> -              (flet ((ps-get-buffer-name () "Agenda View"))
> -                (ps-print-buffer-with-faces file))
> +              ,(flet ((ps-get-buffer-name () "Agenda View"))
> +                 (ps-print-buffer-with-faces file))
>                (message "Postscript written to %s" file))
>               ((string-match "\\.pdf\\'" file)
>                (require 'ps-print)
> -              (flet ((ps-get-buffer-name () "Agenda View"))
> -                (ps-print-buffer-with-faces
> -                 (concat (file-name-sans-extension file) ".ps")))
> +              ,(flet ((ps-get-buffer-name () "Agenda View"))
> +                 (ps-print-buffer-with-faces
> +                  (concat (file-name-sans-extension file) ".ps")))
>                (call-process "ps2pdf" nil nil nil
>                              (expand-file-name
>                               (concat (file-name-sans-extension file) ".ps"))
> --
> 1.7.1
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten