emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] Patchwork: Patch 138 Accepted


From: Friedrich Delgado
Subject: Re: [Orgmode] Patchwork: Patch 138 Accepted
Date: Fri, 16 Jul 2010 15:44:26 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

Carsten Dominik schrieb:
> >I'd appreciate if the subject line and body of those patchwork mails
> >could be a little more informative, since I can't really be bothered
> >to click on those urls in order to figure out what's going on.

> If you are using a threaded email reader, this message will appear
> in the correct thread. I (and I guess John who made the patchwork
> process send a message and in this way automatically inform the
> mailing list about the status of this patch) thought that would be
> good enough. Because if the issue is one that interests you, I'd
> think you are following the thread?

Well, I do read a threaded mailreader, and I noticed that the messages
appeared in threads with patches, but frankly I didn't see the
connection until I read something about what that "patchwork" thingy
actually is, so I didn't see the relevance of those mails at all.

This might actually be enough, indeed.

> The script sending the message is in the repo: UTILITIES/pw.  It
> is written in Python, which I don't know how to write.   I would
> accept a patch which provides a better subject line.
---Zitatende---

Well, a little bit of skimming through the code made me come up with
this 

,----
  diff --git a/UTILITIES/pw b/UTILITIES/pw
  index 5a2e3dd..54ed477 100755
  --- a/UTILITIES/pw
  +++ b/UTILITIES/pw
  @@ -320,9 +320,12 @@ def action_update_patch(rpc, patch_id, state = None, 
commit = None,
   
   This relates to the following submission:
   
  -http://mid.gmane.org/%s''' % \
  -                (patch['id'], patch['id'], state, 
urllib.quote(patch['msgid']))
  -            shortdesc = 'Patch %s %s' % (patch['id'], state)
  +http://mid.gmane.org/%s
  +
  +(%s)
  +''' % \
  +                (patch['id'], patch['id'], state, 
urllib.quote(patch['msgid']), patch['name'])
  +            shortdesc = 'Patch %s %s (%s)' % (patch['id'], state, 
patch['name'])
   
               msg = MIMEText(longdesc)
`----

(Hopefully line breaks won't be garbled...)

But frankly I have no way to test this, so somebody else should
probably look into this.

-- 
        Friedrich Delgado <address@hidden>
                             TauPan on Ircnet and Freenode ;)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]