Re: [Orgmode] Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)

[Eric Schulte]

Fixed, Thanks -- Eric

Erik Iverson <address@hidden> writes:

> Hello,
>
> It looks like the delete-directory bug was fixed, but
> on emacs 23.2 at least, (delete-file) only takes one
> argument, so org-babel-remove-temporary-directory is still
> throwing an error in my case, since we have:
>
>             (delete-file file nil)
>
> --Erik
>
>
>
> Detlef Steuer wrote:
>> Hi Eric,
>>
>> I have to confirm that bug.
>> Org-mode as of today, emacs 23.1.1.
>>
>> Here is, what my *MESSAGES* buffer tells:
>> CONTENTS...done
>> (No files need saving)
>> org-babel-remove-temporary-directory: Wrong number of arguments: 
>> delete-directory, 2
>> When done with a buffer, type C-x #
>> Auto-saving...done
>>
>>
>> Ciao
>> Detlef
>>
>> On Thu, 26 Aug 2010 06:14:26 -0600
>> "Eric Schulte" <address@hidden> wrote:
>>
>>> Hi Noorul,
>>>
>>> Can I ask what error the directory deletion is causing for you?
>>>
>>> I have the following delete-directory in my Emacs (latest from Git)
>>>
>>> ,----[delete-directory]
>>> | delete-directory is an interactive compiled Lisp function in
>>> | `files.el'.
>>> | | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
>>> | | Delete the directory named DIRECTORY.  Does not follow
>>> symlinks.
>>> | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
>>> | TRASH non-nil means to trash the directory instead, provided
>>> | `delete-by-moving-to-trash' is non-nil.
>>> | | When called interactively, TRASH is t if no prefix argument is
>>> | given.  With a prefix argument, TRASH is nil.
>>> | | [back]
>>> `----
>>>
>>> The second argument to `delete-directory' ensures that subdirectories
>>> are recursively deleted.  Are you using a different version of Emacs
>>> (maybe XEmacs?) in which `delete-directory' accepts a different number
>>> of arguments?
>>>
>>> Thanks -- Eric
>>>
>>> Noorul Islam <address@hidden> writes:
>>>
>>>> Latest pull is throwing error while quitting emacs.
>>>>
>>>> Here is the patch to fix this.
>>>>
>>>> ob.el:  Fix minor bug
>>>>
>>>> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number 
>>>> of
>>>> arguments to (delete-directory)
>>>>
>>>> Thanks and Regards
>>>> Noorul
>>>>
>>>> diff --git a/lisp/ob.el b/lisp/ob.el
>>>> index 33dbfef..32e2a54 100644
>>>> --- a/lisp/ob.el
>>>> +++ b/lisp/ob.el
>>>> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
>>>>  (defun org-babel-remove-temporary-directory ()
>>>>    "Remove `org-babel-temporary-directory' on Emacs shutdown."
>>>>    (when (boundp 'org-babel-temporary-directory)
>>>> -    (delete-directory org-babel-temporary-directory t)))
>>>> +    (delete-directory org-babel-temporary-directory)))
>>>>   (add-hook 'kill-emacs-hook
>>>> org-babel-remove-temporary-directory)
>>>>  _______________________________________________
>>>> Emacs-orgmode mailing list
>>>> Please use `Reply All' to send replies to the list.
>>>> address@hidden
>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Please use `Reply All' to send replies to the list.
>>> address@hidden
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>>
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode