emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] Re: [PATCH] Alphabetical ordered lists


From: Nicolas Goaziou
Subject: Re: [Orgmode] Re: [PATCH] Alphabetical ordered lists
Date: Thu, 11 Nov 2010 09:57:58 +0100
User-agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/23.2 Mule/6.0 (HANACHIRUSATO)

Hello,

>>>>> Nathaniel Flath writes:

> Are there any further issues? Thanks, Nathaniel Flath

I've quick checked your patch and it looks like it is doing its job.

Two things to note, though:

1. I strongly recommend that `org-list-can-be-alphabetical' should
   make use of non-interactive forms instead of interactive ones. In
   other words, you should use `org-get-beginning-of-list' and
   `org-get-next-item' instead of `org-beginning-of-item-list' and
   `org-next-item'. You can see my note about it in org-list.el at
   line 856.

   If you have the structure of the list, `caadr' on it (or an
   equivalent if you don't like cl.el) will give you a valid top item
   needed by non-interactive forms.

2. Your patch doesn't apply to current git head, you should correct
   the conflict.


Regards,

-- Nicolas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]