Carsten,
your more general approach works fine for me. The pushed fix seems
allright.
many regards,
Joost
"Carsten" == Carsten Dominik <address@hidden> writes:
Subject: Re: [Orgmode] error in calculating percentages in
clocktables
From: Carsten Dominik <address@hidden>
To: Joost Helberg <address@hidden>
Cc: address@hidden
Date: Fri, 3 Dec 2010 09:52:57 +0100
Hi Joost,
thanks for this, but the new tables are complex and the patch was not
general enough. I have just pushed a fix which I think is correct.
Please verify.
- Carsten
On Nov 29, 2010, at 11:56 AM, Joost Helberg wrote:
ls,
I'm using clocktables and encountered an issue in calculating the
percentage in the last column. Some columns have moved 1 left in the
head-revision, but the generated formula was not changed.
Hence the following patch. The percentages come out OK with this
patch.
Can someone using clocktables verify that this patch is correct and
doesn't break other stuff?
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index eb859df..0c7c73b 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2173,9 +2173,9 @@ from the dynamic block defintion."
(format
"\n#+TBLFM: $%d='(org-clock-time%% @%d$%d $%d..$%d);%%.1f"
pcol
- (+ 2 (if narrow 1 0))
- (+ 3 (if multifile 1 0))
- (+ (if multifile 1 0) 3)
+ (+ 1 (if narrow 1 0))
+ (+ 2 (if multifile 1 0))
+ (+ (if multifile 1 0) 2)
(1- pcol)))
(setq recalc t))
((stringp formula)
regards,
Joost Helberg
--
Snow B.V. http://snow.nl
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
address@hidden
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
--
Snow B.V. http://snow.nl