emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Orgmode] [PATCH] Stable key assignment for org-fast-tag-selection


From: emacs-orgmode
Subject: [Orgmode] [PATCH] Stable key assignment for org-fast-tag-selection
Date: Wed, 12 Jan 2011 14:34:36 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

I noticed that the code to "automatically assign a character" in the
org-fast-tag-selection function assigns a different character depending
on whether or not the tag exists in the current heading.

To see the problem, do the following steps:

- Eval (setq org-use-fast-tag-selection t)
- Eval (setq org-fast-tag-selection-single-key "expert")
- Create a heading with tags :a1:a2:
- Create another heading with tags :a1:a2:
- Type "C-c a", "C-c a", "C-c a", "C-c a"
- Notice how it changes from a1 to a2

Below is a patch to make the character assignment stable, given that all
of the same tags exist in the file each time it's run.

(The tabs messed up the indentation in the git-diff output.)

Regards,
Jason


diff --git a/lisp/org.el b/lisp/org.el
index b2b08ae..fd49f3e 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12947,7 +12947,8 @@ possibly with grouping information.  TODO-TABLE is a 
similar table with
 TODO keywords, should these have keys assigned to them.
 If the keys are nil, a-z are automatically assigned.
 Returns the new tags string, or nil to not change the current settings."
-  (let* ((fulltable (append table todo-table))
+  (let* ((table (sort table (lambda (a b) (string< (car a) (car b)))))
+        (fulltable (append table todo-table))
         (maxlen (apply 'max (mapcar
                              (lambda (x)
                                (if (stringp (car x)) (string-width (car x)) 0))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]