Re: [Orgmode] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]

[Bernt Hansen]

Julien Danjou <address@hidden> writes:

> On Mon, Jan 17 2011, Carsten Dominik wrote:
>
>> have you been following this thread?  I think this has to do with your
>> rewrite of the dagenda span stuff.  Maybe you can find out better and
>> faster that I why this goes wrong?  Please read the entire thread.
>
> I've followed but not sure I understood what the bug is. But from my
> various tries, I found a bug: when pressing 'j', the current span is
> discarded.
>
> Attached is a patch that should fix that, even for future use of
> `org-agenda-list' with the span unspecified. :)

Hi Julien,

Thanks for this patch.  I think this fixes the issue I was having with
'j' in the agenda switching from week-view back to single-day view when
org-agenda-ndays is set to 1.

There is still a (new?) problem with jumping to today.

Set the following variable

(setq org-agenda-start-on-weekday 6)

| Key Sequence | Notes                                          |
|--------------+------------------------------------------------|
| C-c a a      | Display weekly agenda                          |
| f            | Go forward a week                              |
| d            | Display day agenda                             |
| .            | Go to to day - but it goes to Saturday instead |

This should go to today and not the first day of the week.

Regards,
Bernt


>
>
> From 9dd2fe6650b858a4083ebc083bb8d10a0d6ac7f2 Mon Sep 17 00:00:00 2001
> From: Julien Danjou <address@hidden>
> Date: Mon, 17 Jan 2011 16:05:28 +0100
> Subject: [PATCH] Fix agenda span on date jump
>
> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a
> possible default span if it is set.
>
> Signed-off-by: Julien Danjou <address@hidden>
> ---
>  lisp/org-agenda.el |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 0cd620c..0d695b5 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'."
>    (setq org-agenda-last-arguments (list include-all start-day span))
>    (org-compile-prefix-format 'agenda)
>    (org-set-sorting-strategy 'agenda)
> -  (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays 
> org-agenda-span)))
> +  (let* ((span (org-agenda-ndays-to-span (or span
> +                                          org-agenda-current-span
> +                                          org-agenda-ndays
> +                                          org-agenda-span)))
>        (today (org-today))
>        (sd (or start-day today))
>        (ndays (org-agenda-span-to-ndays span sd))
> -- 
> 1.7.2.3