[O] Bug: void-variable filter-buffer-substring-functions [7.5 (release_7.5.384.g94b32)]

[Bernt Hansen]

Hi Eric,

Commit 66e8a4b (Globally replace buffer-substring-filters with
filter-buffer-substring-functions., 2011-06-14) breaks clock reports
with the following backtrace below when org-indent-mode is enabled.

The key sequence to reproduce this error with the minimal emacs setup
below is as follows:

| Key     | Description           |
|---------+-----------------------|
| C-c a a | Go to the agenda      |
| R       | Show the clock report |

Reverting this commit fixes this for me.

Regards,
Bernt

/tmp/test.el
--8<---------------cut here---------------start------------->8---
(setq org-startup-indented t)
--8<---------------cut here---------------end--------------->8---

~/bin/minimal-emacs
--8<---------------cut here---------------start------------->8---
#!/bin/sh
TESTEL=
TESTFILE=/tmp/test.el
if test -e $TESTFILE
then
  TESTEL="-l /tmp/test.el"
fi
emacs -q -l ~/minimal.emacs $TESTEL $1
--8<---------------cut here---------------end--------------->8---

~/minimal.emacs
--8<---------------cut here---------------start------------->8---
(add-to-list 'load-path (expand-file-name "~/git/org-mode/lisp"))
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org-install)

(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(global-set-key "\C-cb" 'org-iswitchb)
--8<---------------cut here---------------end--------------->8---


Debug Backtrace
--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (void-variable filter-buffer-substring-functions)
  add-to-list(filter-buffer-substring-functions 
org-indent-remove-properties-from-string)
  (cond ((org-bound-and-true-p org-inhibit-startup) (setq org-indent-mode nil)) 
((and org-indent-mode ...) (message "org-indent-mode does not work in XEmacs - 
refusing to turn it on") (setq org-indent-mode nil)) ((and org-indent-mode ...) 
(message "org-indent-mode can crash Emacs 23.1 - refusing to turn it on!") 
(ding) (sit-for 1) (setq org-indent-mode nil)) (org-indent-mode (org-set-local 
... nil) (or org-indent-strings ...) (when 
org-indent-mode-turns-off-org-adapt-indentation ...) (when 
org-indent-mode-turns-on-hiding-stars ... ...) (make-local-variable ...) 
(add-to-list ... ...) (org-add-hook ... ... nil ...) (org-add-hook ... ... nil 
...) (org-add-hook ... ... nil ...) (and font-lock-mode ...)) (t 
(save-excursion ...)))
  (let ((last-message ...)) (setq org-indent-mode (cond ... ... ...)) (cond 
(... ...) (... ... ...) (... ... ... ... ...) (org-indent-mode ... ... ... ... 
... ... ... ... ... ...) (t ...)) (run-hooks (quote org-indent-mode-hook) (if 
org-indent-mode ... ...)) (if (called-interactively-p ...) (progn nil ...)))
  org-indent-mode(1)
  (progn (require (quote org-indent)) (org-indent-mode 1))
  (if org-startup-indented (progn (require ...) (org-indent-mode 1)))
  (when org-startup-indented (require (quote org-indent)) (org-indent-mode 1))
  (if org-inhibit-startup nil (when org-startup-align-all-tables (let ... ... 
...)) (when org-startup-with-inline-images (org-display-inline-images)) (when 
org-startup-indented (require ...) (org-indent-mode 1)) (unless 
org-inhibit-startup-visibility-stuff (org-set-startup-visibility)))
  (unless org-inhibit-startup (when org-startup-align-all-tables (let ... ... 
...)) (when org-startup-with-inline-images (org-display-inline-images)) (when 
org-startup-indented (require ...) (org-indent-mode 1)) (unless 
org-inhibit-startup-visibility-stuff (org-set-startup-visibility)))
  (let ((delay-mode-hooks t)) (outline-mode) (setq major-mode (quote org-mode)) 
(setq mode-name "Org") (progn (if ... ...) (unless ... ...) (let ... ...)) 
(use-local-map org-mode-map) (set-syntax-table org-mode-syntax-table) (setq 
local-abbrev-table org-mode-abbrev-table) (if (featurep ...) (when ... ... ... 
...) (define-key org-mode-map [menu-bar headings] ...) (define-key org-mode-map 
[menu-bar hide] ...) (define-key org-mode-map [menu-bar show] ...)) 
(org-load-modules-maybe) (easy-menu-add org-org-menu) (easy-menu-add 
org-tbl-menu) (org-install-agenda-files-menu) (if org-descriptive-links 
(add-to-invisibility-spec ...)) (add-to-invisibility-spec (quote ...)) 
(add-to-invisibility-spec (quote ...)) (when (featurep ...) (org-set-local ... 
t)) (org-set-local (quote outline-regexp) org-outline-regexp) (org-set-local 
(quote outline-level) (quote org-outline-level)) (when (and org-ellipsis ... 
... ...) (unless org-display-table ...) (set-display-table-slot 
org-display-table 4 ...) (setq buffer-display-table org-display-table)) 
(org-set-regexps-and-options) (when (and org-tag-faces ...) (org-set-tag-faces 
... org-tag-faces)) (org-set-local (quote calc-embedded-open-mode) "# ") 
(modify-syntax-entry 64 "w") (if org-startup-truncated (setq truncate-lines t)) 
(org-set-local (quote font-lock-unfontify-region-function) (quote 
org-unfontify-region)) (org-set-local (quote org-table-may-need-update) t) 
(org-add-hook (quote before-change-functions) (quote 
org-before-change-function) nil (quote local)) (org-add-hook (quote 
kill-buffer-hook) (quote org-check-running-clock) nil (quote local)) 
(org-set-autofill-regexps) (setq indent-line-function (quote 
org-indent-line-function)) (org-update-radio-target-regexp) (org-set-local 
(quote beginning-of-defun-function) (quote org-beginning-of-defun)) 
(org-set-local (quote end-of-defun-function) (quote org-end-of-defun)) 
(org-set-local (quote next-error-function) (quote org-occur-next-match)) (if 
org-enforce-todo-dependencies (add-hook ... ...) (remove-hook ... ...)) (if 
org-enforce-todo-checkbox-dependencies (add-hook ... ...) (remove-hook ... 
...)) (org-set-local (quote comment-start) "#") (org-set-local (quote 
comment-padding) " ") (org-set-local (quote align-mode-rules-list) (quote ...)) 
(org-set-local (quote imenu-create-index-function) (quote org-imenu-get-tree)) 
(if (or ... ...) (org-add-hook ... ... ... ...) (org-set-local ... ...)) (and 
org-startup-with-beamer-mode (org-beamer-mode 1)) (set (make-local-variable 
...) (quote org-pcomplete-initial)) (set (make-local-variable ...) (quote 
org-command-at-point)) (set (make-local-variable ...) (quote ignore)) (set 
(make-local-variable ...) (quote org-parse-arguments)) (set 
(make-local-variable ...) "") (if (and org-insert-mode-line-in-empty-file ... 
...) (insert "#    -*- mode: org -*-\n\n")) ...)
  (progn (make-local-variable (quote delay-mode-hooks)) (let (...) 
(outline-mode) (setq major-mode ...) (setq mode-name "Org") (progn ... ... ...) 
(use-local-map org-mode-map) (set-syntax-table org-mode-syntax-table) (setq 
local-abbrev-table org-mode-abbrev-table) (if ... ... ... ... ...) 
(org-load-modules-maybe) (easy-menu-add org-org-menu) (easy-menu-add 
org-tbl-menu) (org-install-agenda-files-menu) (if org-descriptive-links ...) 
(add-to-invisibility-spec ...) (add-to-invisibility-spec ...) (when ... ...) 
(org-set-local ... org-outline-regexp) (org-set-local ... ...) (when ... ... 
... ...) (org-set-regexps-and-options) (when ... ...) (org-set-local ... "# ") 
(modify-syntax-entry 64 "w") (if org-startup-truncated ...) (org-set-local ... 
...) (org-set-local ... t) (org-add-hook ... ... nil ...) (org-add-hook ... ... 
nil ...) (org-set-autofill-regexps) (setq indent-line-function ...) 
(org-update-radio-target-regexp) (org-set-local ... ...) (org-set-local ... 
...) (org-set-local ... ...) (if org-enforce-todo-dependencies ... ...) (if 
org-enforce-todo-checkbox-dependencies ... ...) (org-set-local ... "#") 
(org-set-local ... " ") (org-set-local ... ...) (org-set-local ... ...) (if ... 
... ...) (and org-startup-with-beamer-mode ...) (set ... ...) (set ... ...) 
(set ... ...) (set ... ...) (set ... "") (if ... ...) ...))
  (delay-mode-hooks (outline-mode) (setq major-mode (quote org-mode)) (setq 
mode-name "Org") (progn (if ... ...) (unless ... ...) (let ... ...)) 
(use-local-map org-mode-map) (set-syntax-table org-mode-syntax-table) (setq 
local-abbrev-table org-mode-abbrev-table) (if (featurep ...) (when ... ... ... 
...) (define-key org-mode-map [menu-bar headings] ...) (define-key org-mode-map 
[menu-bar hide] ...) (define-key org-mode-map [menu-bar show] ...)) 
(org-load-modules-maybe) (easy-menu-add org-org-menu) (easy-menu-add 
org-tbl-menu) (org-install-agenda-files-menu) (if org-descriptive-links 
(add-to-invisibility-spec ...)) (add-to-invisibility-spec (quote ...)) 
(add-to-invisibility-spec (quote ...)) (when (featurep ...) (org-set-local ... 
t)) (org-set-local (quote outline-regexp) org-outline-regexp) (org-set-local 
(quote outline-level) (quote org-outline-level)) (when (and org-ellipsis ... 
... ...) (unless org-display-table ...) (set-display-table-slot 
org-display-table 4 ...) (setq buffer-display-table org-display-table)) 
(org-set-regexps-and-options) (when (and org-tag-faces ...) (org-set-tag-faces 
... org-tag-faces)) (org-set-local (quote calc-embedded-open-mode) "# ") 
(modify-syntax-entry 64 "w") (if org-startup-truncated (setq truncate-lines t)) 
(org-set-local (quote font-lock-unfontify-region-function) (quote 
org-unfontify-region)) (org-set-local (quote org-table-may-need-update) t) 
(org-add-hook (quote before-change-functions) (quote 
org-before-change-function) nil (quote local)) (org-add-hook (quote 
kill-buffer-hook) (quote org-check-running-clock) nil (quote local)) 
(org-set-autofill-regexps) (setq indent-line-function (quote 
org-indent-line-function)) (org-update-radio-target-regexp) (org-set-local 
(quote beginning-of-defun-function) (quote org-beginning-of-defun)) 
(org-set-local (quote end-of-defun-function) (quote org-end-of-defun)) 
(org-set-local (quote next-error-function) (quote org-occur-next-match)) (if 
org-enforce-todo-dependencies (add-hook ... ...) (remove-hook ... ...)) (if 
org-enforce-todo-checkbox-dependencies (add-hook ... ...) (remove-hook ... 
...)) (org-set-local (quote comment-start) "#") (org-set-local (quote 
comment-padding) " ") (org-set-local (quote align-mode-rules-list) (quote ...)) 
(org-set-local (quote imenu-create-index-function) (quote org-imenu-get-tree)) 
(if (or ... ...) (org-add-hook ... ... ... ...) (org-set-local ... ...)) (and 
org-startup-with-beamer-mode (org-beamer-mode 1)) (set (make-local-variable 
...) (quote org-pcomplete-initial)) (set (make-local-variable ...) (quote 
org-command-at-point)) (set (make-local-variable ...) (quote ignore)) (set 
(make-local-variable ...) (quote org-parse-arguments)) (set 
(make-local-variable ...) "") (if (and org-insert-mode-line-in-empty-file ... 
...) (insert "#    -*- mode: org -*-\n\n")) (unless org-inhibit-startup (when 
org-startup-align-all-tables ...) (when org-startup-with-inline-images ...) 
(when org-startup-indented ... ...) (unless 
org-inhibit-startup-visibility-stuff ...)))
  org-mode()
  (progn (org-mode) (org-create-dblock props) (org-update-dblock) 
(font-lock-fontify-buffer) (forward-line 2) (buffer-substring (point) (progn 
... ...)))
  (unwind-protect (progn (org-mode) (org-create-dblock props) 
(org-update-dblock) (font-lock-fontify-buffer) (forward-line 2) 
(buffer-substring ... ...)) (and (buffer-name temp-buffer) (kill-buffer 
temp-buffer)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn ... ... 
... ... ... ...) (and ... ...)))
  (with-current-buffer temp-buffer (unwind-protect (progn ... ... ... ... ... 
...) (and ... ...)))
  (let ((temp-buffer ...)) (with-current-buffer temp-buffer (unwind-protect ... 
...)))
  (with-temp-buffer (org-mode) (org-create-dblock props) (org-update-dblock) 
(font-lock-fontify-buffer) (forward-line 2) (buffer-substring (point) (progn 
... ...)))
  org-get-clocktable(:link t :maxlevel 2 :tstart 734301 :tend 734308 :scope 
agenda)
  apply(org-get-clocktable (:link t :maxlevel 2 :tstart 734301 :tend 734308 
:scope agenda))
  (setq tbl (apply (quote org-get-clocktable) p))
  (let ((org-agenda-files ...) (p ...) tbl) (setq p (org-plist-delete p 
:block)) (setq p (plist-put p :tstart clocktable-start)) (setq p (plist-put p 
:tend clocktable-end)) (setq p (plist-put p :scope ...)) (when (and ... ...) 
(setq p ...)) (setq tbl (apply ... p)) (insert tbl))
  (progn (let (... ... tbl) (setq p ...) (setq p ...) (setq p ...) (setq p ...) 
(when ... ...) (setq tbl ...) (insert tbl)))
  (if (and org-agenda-clockreport-mode clocktable-start) (progn (let ... ... 
... ... ... ... ... ...)))
  (when (and org-agenda-clockreport-mode clocktable-start) (let (... ... tbl) 
(setq p ...) (setq p ...) (setq p ...) (setq p ...) (when ... ...) (setq tbl 
...) (insert tbl)))
  (let* ((span ...) (today ...) (sd ...) (ndays ...) 
(org-agenda-start-on-weekday ...) (thefiles ...) (files thefiles) (start ...) 
(day-numbers ...) (day-cnt 0) (inhibit-redisplay ...) s e rtn rtnall file date 
d start-pos end-pos todayp clocktable-start clocktable-end filter) (setq 
org-agenda-redo-command (list ... ... start-day ...)) (dotimes (n ...) (push 
... day-numbers)) (setq day-numbers (nreverse day-numbers)) (setq 
clocktable-start (car day-numbers) clocktable-end (1+ ...)) (org-prepare-agenda 
"Day/Week") (org-set-local (quote org-starting-day) (car day-numbers)) 
(org-set-local (quote org-include-all-loc) include-all) (org-set-local (quote 
org-agenda-current-span) (org-agenda-ndays-to-span span)) (unless 
org-agenda-compact-blocks (let* ... ... ...) (add-text-properties s ... ...) 
(org-agenda-mark-header-line s)) (while (setq d ...) (setq date ... s ...) (if 
... ... ...) (setq files thefiles rtnall nil) (while ... ...) (if 
org-agenda-include-diary ...) (if ... ...)) (when (and 
org-agenda-clockreport-mode clocktable-start) (let ... ... ... ... ... ... ... 
...)) (goto-char (point-min)) (or org-agenda-multi (org-fit-agenda-window)) 
(unless (and ... ...) (goto-char ...) (recenter -1) (if ... ...)) (goto-char 
(or start-pos 1)) (add-text-properties (point-min) (point-max) (quote ...)) (if 
(eq org-agenda-show-log ...) (org-agenda-show-clocking-issues)) 
(org-finalize-agenda) (setq buffer-read-only t) (message ""))
  org-agenda-list(nil nil week)
  eval((org-agenda-list (quote nil) nil (quote week)))
  (let nil (eval org-agenda-redo-command))
  eval((let nil (eval org-agenda-redo-command)))
  org-let(nil (eval org-agenda-redo-command))
  (let* ((org-agenda-keep-modes t) (filter org-agenda-filter) (preset ...) 
(org-agenda-filter-while-redo ...) (cols org-agenda-columns-active) (line ...) 
(window-line ...) (lprops ...)) (put (quote org-agenda-filter) :preset-filter 
nil) (and cols (org-columns-quit)) (message "Rebuilding agenda buffer...") 
(org-let lprops (quote ...)) (setq org-agenda-undo-list nil 
org-agenda-pending-undo-list nil) (message "Rebuilding agenda buffer...done") 
(put (quote org-agenda-filter) :preset-filter preset) (and (or filter preset) 
(org-agenda-filter-apply filter)) (and cols (called-interactively-p ...) 
(org-agenda-columns)) (org-goto-line line) (recenter window-line))
  org-agenda-redo()
  org-agenda-clockreport-mode(nil)
  call-interactively(org-agenda-clockreport-mode nil nil)
--8<---------------cut here---------------end--------------->8---


Emacs  : GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0)
 of 2010-12-11 on raven, modified by Debian
Package: Org-mode version 7.5 (release_7.5.384.g94b32)