emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-crypt: only warn about auto-save-mode when running o


From: Pieter Praet
Subject: Re: [O] [PATCH] org-crypt: only warn about auto-save-mode when running org-decrypt
Date: Sun, 26 Jun 2011 08:38:12 +0200
User-agent: Notmuch/0.5-243-g5a76944 (http://notmuchmail.org) Emacs/23.1.50.1 (x86_64-pc-linux-gnu)

On Fri, 24 Jun 2011 17:50:04 -0400, Nick Dokos <address@hidden> wrote:
> Pieter Praet <address@hidden> wrote:
> 
> > As auto-save-mode can only cause leakage after org-decrypt has been run,
> > there's no need to check for it (and potentially cause annoyance) so early.
> > 
> > Unfortunately, auto-save-mode doesn't set a buffer-local var to indicate
> > whether it's enabled for the current buffer (checking
> > `buffer-auto-save-file-name' has proven to be unreliable), so we can
> > only check whether it's enabled globally, using `auto-save-default'.
> > 
> 
> That's very nice, but I think you can go one step further: Why not turn
> auto-save-mode off for the buffer when org-decrypt is called?  With a
> warning that says so and says why, of course.

Ideally, we'd have a defcustom `org-crypt-auto-save' with the following options:
- 'ask     : Ask the user whether or not to decrypt the entry.
- 'disable : Disable auto-save-mode for the current buffer before decrypting.
- 'ignore  : Decrypt the entry regardless.
- 'encrypt : Re-encrypt the entries before auto-save kicks in.

I've implemented this, but it fails miserably:

Since the function `auto-save-mode' doesn't set an buffer-local
var to indicate whether or not it's enabled for the current buffer, we
can only check for `auto-save-default'. This poses the following problems:

- 'ask will be a serious whiner, prompting the user for each and every
  entry being decrypted, whether or not `auto-save-mode' is enabled for
  the current buffer.
- 'disable will cause (perhaps minor) performance issues, since it will
  try disabling `auto-save-mode' for each and every entry being decrypted,
  even though it may already be disabled for the current buffer.
  If (as per your suggestion) emitting a warning, this will also spam the
  *Message* buffer to no end.

Also, 'encrypt will simply not work, due to `auto-save-hook' not being
called when it's supposed to.


BTW: For those of us running `org-decrypt-entry' with a wrapper function,
do remember one has to call (auto-save-mode -1) instead of (auto-save-mode nil),
since the latter will *toggle* instead of *disable* !

> Nick
> 
> > Signed-off-by: Pieter Praet <address@hidden>
> > ---
> >  lisp/org-crypt.el |   14 +++++++++-----
> >  1 files changed, 9 insertions(+), 5 deletions(-)
> > 
> > diff --git a/lisp/org-crypt.el b/lisp/org-crypt.el
> > index 4bff7a1..f4c0b8e 100644
> > --- a/lisp/org-crypt.el
> > +++ b/lisp/org-crypt.el
> > @@ -142,6 +142,10 @@ This setting can also be overridden in the CRYPTKEY 
> > property."
> >  (defun org-decrypt-entry ()
> >    "Decrypt the content of the current headline."
> >    (interactive)
> > +  (when
> > +      (or
> > +       (not auto-save-default)
> > +       (yes-or-no-p "WARNING: auto-save-mode is enabled globally. This may 
> > cause leakage. Continue? "))
> >    (require 'epg)
> >    (unless (org-before-first-heading-p)
> >      (save-excursion
> > @@ -179,7 +183,7 @@ This setting can also be overridden in the CRYPTKEY 
> > property."
> >         (when heading-was-invisible-p
> >           (goto-char heading-point)
> >           (org-flag-subtree t))
> > -       nil))))))
> > +       nil)))))))
> >  
> >  (defun org-encrypt-entries ()
> >    "Encrypt all top-level entries in the current buffer."
> > @@ -209,10 +213,10 @@ This setting can also be overridden in the CRYPTKEY 
> > property."
> >  ;;     'org-mode-hook
> >  ;;     (lambda () (add-hook 'auto-save-hook 'org-encrypt-entries nil t))))
> >  
> > -(when (and (functionp 'daemonp)
> > -      (not (daemonp)) auto-save-default)
> > -  (message "Warning: turn auto-save-mode off in Org buffers containing 
> > crypted entries.")
> > -  (sit-for 1))
> > +;; (when (and (functionp 'daemonp)
> > +;;            (not (daemonp)) auto-save-default)
> > +;;   (message "Warning: turn auto-save-mode off in Org buffers containing 
> > crypted entries.")
> > +;;   (sit-for 1))
> >  
> >  (add-hook 'org-reveal-start-hook 'org-decrypt-entry)
> >  
> > -- 
> > 1.7.4.1
> > 
> > 

Peace

-- 
Pieter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]