Re: [O] [PATCH] Re: Latex Export: Place Caption Below Table

[Carsten Dominik]

On 3.10.2011, at 16:43, Nick Dokos wrote:

> Eric S Fraga <address@hidden> wrote:
> 
>> address@hidden (Thomas S. Dye) writes:
>> 
>>> Nick Dokos <address@hidden> writes:
>> 
>>>> The following patch (deliberately hidden as a binary octet-stream to keep 
>>>> it
>>>> out of patchwork) will do that - but IMO, it would be better to have yet 
>>>> another
>>>> user-settable option to control the placement.
>>>> 
>>>> Nick
>>>> 
>>>> 
>>> 
>>> Aloha all,
>>> 
>>> The inlined patch introduces a variable
>>> org-export-latex-table-caption-above to control the placement of table
>>> captions.  Thanks to Nick Dokos for leading the way on this.
>>> 
>>> Tom
>> 
>> 
>> thanks for doing this -- I was swamped last week so had no chance of
>> following the thread until today!
>> 
>> One comment on the last version of the patch: would it not be better for
>> the variable to be a defcustom variable instead of defvar?
> 
> I agree - being able to customize variables without resorting to lisp is
> generally preferable: it is friendlier to newcomers and it allows even
> experienced users to find the various knobs.

If you provide a new patch doing a defcustom, I think this patch would be
good to have.  Please go ahead and check it in!

- Carsten

> 
> If the patch is deemed acceptable, it might also be nice to be able to
> set the variable per-file through the OPTIONS line, but that can
> certainly wait.
> 
>> Otherwise,
>> the patch looks fine to me although I'm unlikely to use the new
>> functionality ;-)
> 
> Unless you try to publish an article in a journal with a perverse layout
> policy :-)
> 
> I applied the patch and took it for a short spin. git complained about
> trailing whitespace:
> 
> ,----
> | /home/nick/Mail/inbox/1021:197: trailing whitespace.
> |                         (if (and floatp 
> org-export-latex-table-caption-above) 
> | /home/nick/Mail/inbox/1021:212: trailing whitespace.
> |                         (if (and floatp (not 
> org-export-latex-table-caption-above)) 
> | /home/nick/Mail/inbox/1021:225: trailing whitespace.
> |                     (if (not org-export-latex-table-caption-above) tbl) 
> | /home/nick/Mail/inbox/1021:231: trailing whitespace.
> |                     (if org-export-latex-table-caption-above tbl) 
> | warning: 4 lines add whitespace errors.
> `----
> 
> but other than that the patch worked fine.
> 
> Thanks, Tom!
> Nick
> 
> 
>