Re: [O] Temp files from testing are permanent...

[Eric Schulte]

Achim Gratz <address@hidden> writes:

> Eric Schulte <address@hidden> writes:
>> It will be up to the authors of individual tests to remove tangled and
>> exported files.  Ideally we can patch each test to clean up after
>> itself.  Perhaps we should provide a test macro which accepts a list of
>> file names and optionally removes them if the test exists successfully.
>> e.g.,
>>
>> (org-test-with-cleanup '("exported.html" "tangled.sh" etc...)
>>   ...test body...)
>
> Currently those files would have inpredictable names AFAICS, which would
> defeat that purpose.

I should have been more clear.  I'm thinking that this would be a macro
used /within/ unit tests so that testers could specify what files will
be created (test writers should be able to predict the file names
created by their tests) and then the macro will handle cleanup.  Here's
one implementation of such a macro

  (defmacro org-test-with-cleanup (files &rest body)
    "If BODY executes successfully delete FILES and return results of BODY."
    (declare (indent 1))
    `(let ((result (progn ,@body)))
       (mapc (lambda (file) (when (file-exists-p file) (delete-file file))) 
files)
       result))

> I'm not sure where to do this, but it occurs to me that it would be
> easier if those files only had a unique prefix that didn't change for
> each invocation of the test suite (a timestamp would be OK, so it is
> easier to see which files you're looking at).  If the files always had
> the same name, you would have to make sure that there was no
> collision, either with existing files or results from earlier tests,
> so that would be no good.  If it is easier to always have the same
> names for the files, one could just make the test directory name
> unique.  I think it is useful for debugging to be able to keep a few
> generation of tests around.
>

I do like the idea of a single directory in which all output files may
be collected.  The only potential downside I see for this is that files
will be generated both from within org files in the testing/examples
directory as well as temporary files.

>
>> Even if the above is implemented this sounds like a good safeguard.
>
> Safeguards are in place in my Makefile fork.
>
>
> Regards,
> Achim.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/