emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790


From: Bastien
Subject: Re: [O] [bug] Org mode repo broken as of abbea596111611a945d73783b3e8790e76599740, org-element.el missing
Date: Sat, 28 Jul 2012 08:41:02 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux)

Achim Gratz <address@hidden> writes:

> Kyle Machulis writes:
>> In commit abbea596111611a945d73783b3e8790e76599740, the commit message
>> starts with
>>
>> - Move org-element.el from contrib/lisp to lisp/.
>>
>> However, it looks like org-element.el just got deleted, not moved.
>> This causes much badness when trying to rebuild.
>
> Thanks for reporting, it seems Bastien missed a 'git add
> lisp/org-element.el' before doing this commit

Indeed.  Thanks for fixing this!

> (and broke a few other
> things with additional changes in the same commit).  I don't know if the
> changes in org.el were intended to go live since there is no changelog
> entry for those.  

There is a general ChangeLog: 

  Also move chunks of declarations and require statements to
  get rid of compiler warnings.

> If not, they will have to be reverted/changed
> seperately but for now things compile and test cleanly again.

I opened a can of wo^W^Wcompiler warnings while moving org-element.el
to core: the way org.el requires libraries or those libraries require
'org is confusing, and there is still room for simplification.  Let's 
do this incrementally.

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]