emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] bug#12905: 24.2.50; org: edit source block causes data loss


From: Bastien
Subject: Re: [O] bug#12905: 24.2.50; org: edit source block causes data loss
Date: Fri, 14 Dec 2012 10:38:11 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

Hi Le,

Le Wang <address@hidden> writes:

> If I press C-' before on a line BEFORE "+begin_src ...", then doing
> comparison with ">=" with beg==nil and end==nil causes
> "wrong-type-argument" error.

I think the check should happen before, see how I did it here:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=81d5eb

> "test-org-src/point-outside-block" test case should fail, but because
> "wrong-type-argument" is also an error, it is passing.  :(
>
> I've changed "(error ..." to raise an org-src specific error to
> facilitate testing.  Commits rebased to master are attached.

Using signal makes sense if our testing suite uses it, yes.
Can you merge your patches and provide a ChangeLog when the
change affects org-src.el (and possibly test-org-src.el too)?  

Thanks a lot!

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]