[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Babel support for scheme using geiser
From: |
Bastien |
Subject: |
Re: [O] [PATCH] Babel support for scheme using geiser |
Date: |
Sun, 06 Jan 2013 07:56:00 +0100 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) |
Hi Michael,
Michael Gauland <address@hidden> writes:
> Bastien <bzg <at> altern.org> writes:
>> In the meantime, please consider adding a
>> commit ChangeLog for your patch,
>
> Most of the file has changed dramatically--would you like the changelog to
> list
> all the functions that have been added or altered, or would a simple statement
> that the file underwent a major re-write be more appropriate?
Well, I'm afraid we'll have to go the clean way: just document
the deleted functions, the new ones, and the ones that have been
rewritten. No need to go too much into details.
Also let's rename `cleanse-org-babel-scheme-repl-map' to
`org-babel-scheme-cleanse-repl-map'.
>> ...avoid dangling parentheses,
>
> Noted. That's a bad habit I've picked up somewhere (probably too many years
> of C
> programming.)
>
>> and don't overwrite the first line... we are in 2013
>
> Also noted. Part of my brain refuses to acknowledge the new year until I'm
> back
> at work. Regrettably, that won't be a problem after tomorrow.
Hehe, happy new year :)
--
Bastien