Re: [O] [PATCH] ob-R.el, ox-latex.el: support for tikz graphics

[Nicolas Goaziou]

Hello,

Achim Gratz <address@hidden> writes:

> A .tikz file usually contains a tikzpicture environment that wraps around the
> actual tikz code.  It produces a box just like includegraphics does, only that
> it is normal LaTeX code, and so you need \include to read it.

Ok, thank you.

>> If it doesn't, it may be better to implement a dedicated (or a more
>> general "input" function) formatting function that would be called from
>> `org-latex-link'.
>
> I don't understand.  What I currently need to do for TikZ is this:
>
> #+LaTeX: \begin{figure}[t]\centering
> #+LaTeX:   \input{oldModel.tikz}
> #+LaTeX:   \caption{Relative modelling error}
> #+LaTeX: \label{fig:oldModel}
> #+LaTeX: \end{figure}

  #+begin_latex
  ...
  #+end_latex

would be easier.

> With the patch that becomes much easier 

[...]

I'm not questioning the usefulness of the patch. I want to know if
`org-latex--inline-image' is the appropriate function to provide that
feature or if the feature should be provided through another function.

In particular, `org-latex--inline-image' provide options to wrap the
picture in wrapfigure environment, or to set width optional argument for
includegraphics. If it doesn't make sense in this case, the code could
as well be moved into another function, like `org-latex--input-file',
which would handle options specific for \input.


Regards,

-- 
Nicolas Goaziou