emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] org-agenda-write taking very long (probably because of babel)


From: Bastien
Subject: Re: [O] org-agenda-write taking very long (probably because of babel)
Date: Thu, 28 Feb 2013 09:56:53 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

Hi Achim,

Achim Gratz <address@hidden> writes:

> * lisp/ob-core.el (org-babel-execute-src-block): Do not ask for
>   confirmation if the cached result is current.  Since
>   `org-babel-confirm-evaluate´ does additional things besides asking
>   for confirmation, call it first with `org-confirm-babel-evaluate´
>   bound to nil.  This has the effect that it will never ask the user,
>   but will indicate if the block should be evaluated.  If yes,
>   determine whether the cached result block is current (this is
>   deferred until now since `org-babel-process-params´ might trigger
>   expensive operations).  If `cache-current-p´ is t or
>   `org-confirm-babel-evaluate´ is nil, evaluate the source block
>   without asking.  In case the cache is current the evaluation will
>   not actually do anything but return the cached value, so this is
>   safe.  In case `org-confirm-babel-evaluate´ is nil the user would
>   not be asked anyway, so the call of `org-babel-confirm-evaluate´ is
>   not necessary.  Otherwise run `org-babel-confirm-evaluate´ again to
>   ask permission from the user and act depending on the answer.

Sorry to nitpick on this but please keep the Emacs-like change log
small, if not terse.  Additionnal details are more than welcome in
the commit message though.

Thanks!

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]