Re: [O] [PATCH] Smart inference of task progress when exporting to TJ3

[Christian Egli]

Hi Martin

Martin Becker <address@hidden> writes:

> Thank you for these remarks, next time I know.
> I attached a "clean" patch.

I like this patch, this is good stuff. Can you tell me how you use this?
I.e. does tj3 adapt the length fo a task based on your clock table?

A few remarks on the patch from my side:

+          ;; state=done => complete=100
+          (if (eq (org-element-property :todo-type task) 'done) 100.0
+            ;; else if explicit property => use that
+            (if complete-explicit (string-to-number complete-explicit)
+              ;; else guess the completeness from clocksum              
+              (let* ((clocked (org-taskjuggler--clocksum-task task))
+                     (complete-guess 
+                     (and effort (/ (* 100 clocked) 
+                      (org-duration-string-to-minutes effort)))))
+                (and complete-guess (max (min 99 complete-guess) 0)))
+             )))

I would write this using cond instead of nested if. Makes it more clear.

>>     2. IIUC you don't need the TINYCHANGE cookie because the changes
>>     are made in contrib/ which doesn't require copyright assignment.

The taskjuggler exporter used to be in core before it was moved to
contrib by Bastien or Nicolas on the bases that there aren't many users
(and probably because it wasn't maintained very well). This is OK for
now, but eventually I'd like to move it back to core. So we need
assignment for this patch.

Thanks
Christian
-- 
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland