emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Do not indent option keywords


From: Achim Gratz
Subject: Re: [O] [PATCH] Do not indent option keywords
Date: Fri, 10 May 2013 08:39:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Carsten Dominik writes:
> by decoration you mean font-lock support?

Yes, but I also don't think these should ever become indented in the
first place.  That's debatable of course, the syntax as defined by
org-element does not require this IIRC.

> Maybe this would be a better fix:
>
>       Modified lisp/org.el
> diff --git a/lisp/org.el b/lisp/org.el
> index 745fb82..43df094 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -5867,7 +5867,8 @@ by a #."
>          ((or (equal dc1 "+results")
>               (member dc1 '("+begin:" "+end:" "+caption:" "+label:"
>                             "+orgtbl:" "+tblfm:" "+tblname:" "+results:"
> -                           "+call:" "+header:" "+headers:" "+name:"))
> +                           "+call:" "+header:" "+headers:" "+name:"
> +                           "+options:"))
>               (and (match-end 4) (equal dc3 "+attr")))
>           (add-text-properties
>            beg (match-end 0)

Sure, that helps too and has certainly less potential for controversy.

I think we should make an effort to shift most if not all the regex
stuff in org.el into org-element.  There's far too much duplication with
subtle differences sprinkled all over the place to get match data to
work with and it's almost hopeless to try and find all such uses for a
single element.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds




reply via email to

[Prev in Thread] Current Thread [Next in Thread]