emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup


From: Rasmus
Subject: Re: [O] [PATCH][ox-koma-letter]: sender, email and cleanup
Date: Sun, 26 May 2013 16:36:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Viktor,

>>   1. Viktor's latest patch.
>>   2. The patch describe above that gets user name and email and works
>>      on my system. . .
>
> Your code works for me. From my point of view, the pros are that per
> default `org-koma-letter-{author,sender}' pick up the values of
> `user-full-name' and `user-mail-address' whenever they are changed.
> That's very nice! The cons are that IHMO it's quite complicated for
> setting something as simple as author and email and you mentioned a
> possible crash which I did not test further. Could this be tested using
> `functionp'? Still, I think we should stick with it for now.

functionp seems better, yes.  I didn't know about it (doh!).  Thanks!

While it is complicated I think it's OK given our desire to disable
author and still have a similar default to ox-latex.el.  Also, it
allows for arbitrary functions which could potentially determine the
name based on the context of the letter (I don't know since it's
already initialized in the options-alist).

I'll let you and Alan decide.

> As a side note, I had quite a few problems working with your patches.
> None of them applied against master, or against my latest patch as you
> claimed. 

Right.  I was working off of branch and I guess one reasons is that it
was against the history of my previoues patches—of which not all was
applied to the master, it seems (?).  I've now tried to rework the
entire thing against the current master and produces simplified
patches.  I tested them with git am and they work on my system.

There are still things I don't understand such as why git wants to
re-add the authors in patch 4 but I've spend way to much time on
rebasing and understanding git already and my head hurts.  It seems to
ignore it when using git am.

Before applying the patches my git log says

commit 847637f4bdacb861723438c1389f1a3bcdac48af
Merge: 43cc5be 206762b
Author: Nicolas Goaziou <address@hidden>
Date:   Sat May 25 22:03:48 2013 +0200

    Merge branch 'maint'

Patches:

1. summarizes all changes in author.  It uses my solution as mentioned above.
2. full support for after closing keywords.  See commit message
3. signature to nil
4. change handling of subject and allow for setting subject in OPTION-line.


> I had to merge in some of the changes of 0002 by hand. I
> suggest that we nail down the workings of AUTHOR and EMAIL first (should
> be done now) and then start with clean separate branches branched from
> master for your subject and heading code.

>  We could even use github for this, what do you think?

Yeah, could be better.  It's way too hectic with all the patches and
keeping track of moving repos.  If you think it can ease the burden of
collaborating I'm all for it.

I tried to make a git repo retaining the history of ox-koma-letter.el,
but I ended up with a repo of 42mb even after applying all the
"garbage collection" tips the interweb had to offer. . .

I'm indifferent between bitbucket and github btw, but I'd prefer it
someone with more git skills would set it up.

-Rasmus

-- 
m-mm-mmm-mmmm bacon!

Attachment: 0001-ox-koma-letter.el-org-koma-letter-author-defaults-to.patch
Description: Text Data

Attachment: 0002-Added-support-for-after-closing-and-after-document.patch
Description: Text Data

Attachment: 0003-change-default-of-org-koma-letter-signature-to-nil.patch
Description: Text Data

Attachment: 0004-ox-koma-letter-changed-handling-of-subject.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]