Re: [O] Proper use of 'org-file-apps'

[Nick Dokos]

Vladimir Lomov <address@hidden> writes:

> Something like that?

The only question I had was whether there should be a \\' at the end of
the xhtml line. I'm not sure how much real difference it makes, but I
wonder if its absence is going to trip up somebody: "Why do the other
two have a \\' but this one doesn't?"

But I'll let you decide whether it should be present or not. It's
already an improvement as it stands.

I did apply the patch btw and checked that the docstring is as it
should: it's good to go (with the above caveat).

>
> From 7840435bd76b38ab536108dfc105fdc53a6aa80d Mon Sep 17 00:00:00 2001
> From: Vladimir Lomov <address@hidden>
> Date: Fri, 28 Jun 2013 08:42:15 +0900
> Subject: [PATCH] Fix docstring for `org-file-apps'
>
>   * lisp/org.el: `org-file-apps' docstring: doubled backslashes (would
>     give usable output when run 'C-h v org-file-apps') and use correct
>     regexp to match digits.
>
>   TINYCHANGE
> ---
>  lisp/org.el | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index d0dffc7..5e56231 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -1940,8 +1940,8 @@ file identifier are
>                   filename matches the regexp.  If you want to
>                   use groups here, use shy groups.
>  
> -                 Example: (\"\\.x?html\\'\" . \"firefox %s\")
> -                          (\"\\(?:xhtml\\|html\\)\" . \"firefox %s\")
> +                 Example: (\"\\\\.x?html\\\\'\" . \"firefox %s\")
> +                          (\"\\\\(?:xhtml\\\\|html\\\\)\" . \"firefox %s\")
>                            to open *.html and *.xhtml with firefox.
>  
>                 - Regular expression which contains (non-shy) groups:
> @@ -1956,7 +1956,7 @@ file identifier are
>                   In a custom lisp form, you can access the group matches with
>                   (match-string n link).
>  
> -                 Example: (\"\\.pdf::\\(\\d+\\)\\'\" . \"evince -p %1 %s\")
> +                 Example: (\"\\\\.pdf::\\\\([[:digit:]]+\\\\)\\\\'\" . 
> \"evince -p %1 %s\")
>                       to open [[file:document.pdf::5]] with evince at page 5.
>  
>   `directory'   Matches a directory

-- 
Nick