Re: [O] [PATCH] ox-icalendar: fix handling of timestamps

[Viktor Rosenfeld]

Hi Nicolas,

Viktor Rosenfeld wrote:

> So I propose to append the docstring of
> `org-icalendar-export-timestamps':
> 
>   This variable has precedence over and overrides the behavior of
>   `org-export-with-timestamps'. The setting is applied to every
>   timestamp below a headline and not only to those which are isolated in
>   a paragraph containing only timestamps.
> 
>   It can also be set with the #+OPTIONS line, e.g. "<:t". 

I just realized that this is not enough. The option
`org-icalendar-with-timestamps' already changes the meaning of
`org-export-with-timestamps'. The latter only removes timestamps from
the export whereas during the iCalendar export the presence of a
timestamp determines whether the heading is exported at all. So it's
more akin to the behavior of :export: and :noexport: tags.

I would change the docstring of `org-icalendar-export-timestamps' as
such:

  Non-nil means export headlines with timestamps.
 
  It can be set to any of the following values:
    t           export headlines containing any kind of timestamp
    `active'    export headlines containing active timestamps
    `inactive'  export headlines containing inactive timestamps
    nil         do not any headlines

  Note: This variable overrides the behavior of
  `org-export-with-timestamps'.  `org-export-with-timestamps' controls
  whether a timestamp is exported or removed from the export.
  `org-icalendar-export-timestamps' controls whether a headline is
  exported or removed from the exported. In addition,
  `org-icalendar-export-timestamps' applies to every timestamp below a
  headline and not only to those which are isolated in a paragraph
  containing only timestamps.

  This variable can also be set with the #+OPTIONS line, e.g. "<:t". 

Note that setting the variable in the OPTIONS line is useful to remove a
file from the iCalendar export even though it is displayed in the
agenda. I actually have this usecase (although right now I exclude by
tag).

Cheers,
Viktor