Re: [O] [patch][ox-koma-letter] set opening via headline

[Nicolas Goaziou]

Hello,

Rasmus <address@hidden> writes:

> With the following patch one can set the opening via a headline.
> Currently, it's pretty conservative and will only set opening if it
> isn't set already.  I'm open to discussion on that point.

Here are some comments about its internals.

>  (defcustom org-koma-letter-opening nil
> -  "Letter's opening, as a string."
> +  "Letter's opening, as a string.  If (1) this value is nil; (2)

Please start a new line after the first sentence.

> +(defcustom org-koma-letter-headline-is-opening-maybe t
> +  "Whether a headline may be used as an opening.  A headline is

Ditto.

> +      (unless (or (plist-get info :opening)
> +               (not org-koma-letter-headline-is-opening-maybe))
> +     (plist-put info :opening (org-element-property :raw-value headline)))

I suggest to use

  (org-export-data (org-element-property :title headline) info)

instead, so you can correctly export Org syntax included in the
headline, if any.


Regards,

-- 
Nicolas Goaziou