Re: [O] [RFC] Change some defcustoms into defcont

[Nicolas Goaziou]

Hello,

Carsten Dominik <address@hidden> writes:

> I think this change breaks user setups.  I don't know how many
> people do change these keywords, but I know some do, if
> only for localization purposes.  I myself have modified the
> archive keyword in some cases, if I use this feature for a
> different purpose.

I don't think it breaks their setup, since you can do:

  (setq org-deadline-string "SOMETHING:")

Of course, if they change it with `custom-set-variables', they will have
to change it.

> You probably want to do this to make Org syntax less fragile.  

Correct.

> However, I think it can also be achieved by leaving these as defcustom
> and discouraging changes in the docstring with a standard sentence
> about about deprecation.

That's exactly the point of the defconst: you can still modify the
variable, but it sends a strong message to the user. Also, it's not
about deprecation: code base should still rely on these variables.

> Your most important argument to me seems about efficiency of cashing.
> We can fix this by providing :set methods for the customize entries
> that will trigger global cache erasing, so that you do not need to
> programmatically check this all the time.

I know, and I still have to do it for variables like
`org-todo-keywords', which are meant to be modified.

My main concern is about core Org syntax.


Regards,

-- 
Nicolas Goaziou