Re: [O] [PATCH] hide inline-tasks in 'children visibility state

[Nicolas Goaziou]

Hello,

address@hidden (Jonas Hörsch) writes:

> one more patch, which takes care of re-hiding inline-tasks
> properly. finally it is possible to work with longer inline tasks
> without them getting always in the way.

Thank you for the patch. Here are a few comments.

> Subject: [PATCH] org-inlinetask: hide inline tasks in 'children visibility
>  state

Nitpick: you need a capital letter after colons.
>
> * lisp/org.el (org-cycle-hide-inline-tasks): re-hide inline tasks when
>   switching to 'children visibility state.

Ditto.

> +  "Re-hide inline tasks when switching to 'contents or 'children
> +visibility state."
> +  (cond ((eq state 'contents)

I suggest to use `case' here, but it's really a matter of style.

> +      (when (and (boundp 'org-inlinetask-min-level)
> +                 org-inlinetask-min-level)

  (and (boundp 'var) var) => (org-bound-and-true-p var)

> +        (hide-sublevels (1- org-inlinetask-min-level))))
> +          (while (and (outline-next-heading)
> +                      (org-inlinetask-at-task-p))

I think it is more efficient to directly look for inlinetasks since you
can use `org-inlinetask-outline-regexp'.


Regards,

-- 
Nicolas Goaziou