Re: [O] Bug? org-set-tags never uses ido

[Eric Abrahamsen]

Anders Johansson <address@hidden> writes:

> Greetings,
> I want to use ido everywhere and wanted to know why this doesn't seem
> to work for setting org-mode tags (it never has for me).
>
> Using edebug to step through the call to org-icompleting-read which
> org-set-tags does I can see that it never gets to using ido since the
> last condition below is false:
> org.el:10147-10150 (package repository version 20131028):
>    (if (and org-completion-use-ido
>         (fboundp 'ido-completing-read)
>         (boundp 'ido-mode) ido-mode
>         (listp (second args)))
>
> This is not strange, since org-icompleting-read is called like this in
> org-set-tags:
>
> org.el:14519-14521
>                (org-icompleting-read "Tags: "
>                          'org-tags-completion-function
>                          nil nil current 'org-tags-history))))))

Hmm, shouldn't that 'org-tags-completion-function be replaced with
org-last-tags-completion-table? A quick test shows that works, and from
glancing at the code it seems like org-last-tags-completion-table should
hold the proper assortment of tags...

E

>
> ido apparently needs a list of possible completions, not a single symbol.
>
> I don't understand much more of this really.
> Is it a bug? Have I misunderstood something?
>
> Greetings,
> Anders Johansson