[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance
|
From: |
Achim Gratz |
|
Subject: |
Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance |
|
Date: |
Mon, 17 Mar 2014 20:49:24 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
Bastien writes:
> Achim Gratz <address@hidden> writes:
>
>>> Can you tell a bit more about what's wrong with the test?
>>
>> There is nothing wrong with those tests.
>
> I meant: can you tell me how the tests fail?
They don't produce the result they are supposed to produce.
> I'm interested in the answer.
make BTEST_RE='\\(header-arg-defaults\\|property-accumulation\\)' test-dirty
>>> If the patch is good and the tests are outdated, I'd rather
>>> fix the tests than revert the patch to re-revert it again.
>>
>> No, the patch is bad, otherwise it wouldn't break the tests.
>
> Sorry, I don't buy this.
I'm not selling anything.
> Or maybe explain me why the patch is wrong.
It breaks property inheritance and accumulation.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
- [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Ilya Shlyakhter, 2014/03/07
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/14
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Achim Gratz, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Achim Gratz, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance,
Achim Gratz <=
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Achim Gratz, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Ilya Shlyakhter, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Achim Gratz, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Ilya Shlyakhter, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/17
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/18
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Bastien, 2014/03/18
- Re: [O] [PATCH] Fixed bug in org-entry-get-with-inheritance, Ilya Shlyakhter, 2014/03/18