[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-plot: Handle explicit date/time index
From: |
Yasushi SHOJI |
Subject: |
Re: [O] [PATCH] org-plot: Handle explicit date/time index |
Date: |
Tue, 25 Mar 2014 06:37:45 +0900 |
User-agent: |
Wanderlust/2.15.9 |
Hi Bastien,
At Sun, 23 Mar 2014 19:41:45 +0100,
Bastien wrote:
>
> Yasushi SHOJI <address@hidden> writes:
>
> > * lisp/org-plot.el (org-plot-quote-tsv-field): Dump data as is when
> > `timeind' is set.
>
> This change produces a compiler warning:
>
> In org-plot-quote-tsv-field:
> org-plot.el:113:22:Warning: reference to free variable `params'
Thank you for catching this.
I guess I have to re-think the whole thing. The current code by-passes
the quoting function for _all_ fields, not just for the index when
`timeind' is present. This surely breaks for others.
I don't have much time today. So, please give me a day or two.
Meanwhile, Bastien, would you mind to revert the commit for me?
Thanks,
--
yashi