[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [RFC] [PATCH] ob-core.el: allow the auto-generation of output fi
|
From: |
Achim Gratz |
|
Subject: |
Re: [O] [RFC] [PATCH] ob-core.el: allow the auto-generation of output file names for src blocks. |
|
Date: |
Wed, 14 May 2014 19:46:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Aaron Ecay writes:
> Thanks again for the feedback. I just pushed the revised patch to master.
>
>>> I think I would prefer the code in this patch to do nothing in this case
>>> (not create a :file value), but for language-specific code that needs a
>>> :file to raise an error to prompt the user to add a name.
>>>
>>
>> Fair enough, especially given that this default will be applied to *all*
>> code blocks, this seems like a reasonable approach.
>
> I went ahead with my suggested approach here.
That breaks the tests for Octave and Maxima; since you're intentionally
not keeping backwards compatibility here this should be fixed in the
tests, I'd think.
Also, I'd think you should be using "user-error" instead of error to
generate the messages.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds