Re: [O] babel C, C++, D enhancement

[Eric Schulte]

Achim Gratz <address@hidden> writes:

> Eric Schulte writes:
>> This new patch looks great, and the test suite passes locally.  I've
>> just applied it.
>
> You also get a warning from the byte-compiler on something that is
> clearly a bug.  I think the fix should be:
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/ob-C.el b/lisp/ob-C.el
> index dd03fa7..a794e2a 100644
> --- a/lisp/ob-C.el
> +++ b/lisp/ob-C.el
> @@ -264,7 +264,7 @@ (defun org-babel-C-val-to-C-type (val)
>            (list
>             (if (equal org-babel-c-variant 'd) "string" "const char*")
>             "\"%s\""))
> -         (t (error "unknown type %S" type)))))
> +         (t (error "unknown type %S" basetype)))))
>      (cond
>       ((integerp val) type) ;; an integer declared in the #+begin_src line
>       ((floatp val) type) ;; a numeric declared in the #+begin_src line
> --8<---------------cut here---------------end--------------->8---
>

Agreed, I've just pushed up a fix.  Please feel free to push these sorts
of obvious bug fixes yourself in the future.

>
> The type determination is a tad optimistic, too.  An Emacs integer may
> or may not fit into C type "int" depending on how Emacs is compiled and
> which compiler you are using.
>

Certainly, more refinement wouldn't hurt.

Best,
Eric

>
>
> Regards,
> Achim.

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D (see https://u.fsf.org/yw)