Re: [O] [PATCH] -for review- Tangling with variable transfer of variables

[Charles C. Berry]

On Mon, 23 Jun 2014, Rainer M Krug wrote:

> "Charles C. Berry" <address@hidden> writes:
>
> V> On Fri, 20 Jun 2014, Rainer M Krug wrote:
> > > Attached please find =the reworked patch.
> > >
> > > 1) uses local() and closes connection
> > > 2) does not leave a variable cal;led file behind

[deleted]

> OK - attached please find two patches:
>
> 0001-lisp-ob-R.el-Fix-tangling-with-tables.patch
> 0002-Make-transfer-of-values-from-R-type-aware.patch
>
> The first one fixes tangling with tables including discussed
> suggestions, the second one moves the definition of the R code into
> defconst and introduces type awareness for the transfer of *values*, but
> not tables. I reworked your suggestion and now integer are transferred
> to R as integers (L) and float as double.
> This already worked for tables.
>
> Could you please check the second patch? In my checks everything worked
> as expected.

I think these are good to go.

I checked several cases and all seemed to work as expected.

Some comments on this and your recent posts in this thread:

I see you took the suggestion to use (prin1-to-string value) on the 
'left-over' objects. With that stuff like :var x=[1 2 3] will work. :-)

The only failure I could trigger was with this block:

#+BEGIN_SRC R :session :var x=(org-export-get-backend 'latex)
x
#+END_SRC

which triggered 'Eval buffer', added a bunch of ^G's to my session log, 
and hung until I ran C-g (keyboard-quit).

When run with :session none, it works. I suspected the long string tripped 
over a limitation or bug in iESS-mode or comint-mode, but this runs:

#+BEGIN_SRC R :session :var x=(append (make-vector 10000 '(1 2)) '((1 2 3))) 
:results output
summary(x)
#+END_SRC

so I am not sure what gives.

Chuck