[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [bug?] org-copy-face doesn’t add faces to org-faces customize gr
From: |
Sebastien Vauban |
Subject: |
Re: [O] [bug?] org-copy-face doesn’t add faces to org-faces customize group |
Date: |
Tue, 23 Sep 2014 20:00:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.93 (windows-nt) |
Hi Aaron,
Aaron Ecay wrote:
> 2014ko irailak 23an, Sebastien Vauban-ek idatzi zuen:
>> Aaron Ecay wrote:
>>> 2014ko abuztuak 29an, Sebastien Vauban-ek idatzi zuen:
>>>> I think it's related to an Emacs bug (#16440) which I reported on the
>>>> Org mailing list in February.
>>>
>>> I don’t completely understand what is going on in that bug report. My
>>> proposal is to convert org-copy-face to defface.
>>
>> I think this is "the right thing" (TM).
>>
>>> I can’t tell if this would fix your problem or not, but if it’s
>>> exclusive to the faces I listed in my previous email the answer is
>>> probably “yes.”
>>
>> From what I can see, yes, the faces which are wrongly displayed (before
>> re-applying the theme) match the ones defined by `org-copy-face'. So,
>> this seems the right way to go.
>
> OK, thanks for the followup. I’m attaching the patch to this email. If
> I don’t hear any further feedback, I’ll commit it to master in a few
> days.
I'd say: commit it now, so that it really gets to a broad audience.
Anyway, would there be problems, they would be very, very limited: face
problems, that's all!
Best regards,
Seb
--
Sebastien Vauban