Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

[Aaron Ecay]

Hi Nicolas,

2014ko irailak 23an, Nicolas Goaziou-ek idatzi zuen:
> 
> Hello,
> 
> Aaron Ecay <address@hidden> writes:
> 
>> Thanks for all your feedback.  The patch is now applied on master.
> 
> Thank you.
> 
>> I’m confused about how ‘org-latex--wrap-label’ works.  It tries to
>> put \label commands outside of floats.  That will yield links that
>> jump to the preceding section, not the specific point in the document
>> where the \label command occurs.  Probably this command should insert
>> \phantomsection before the \label, so that resultant links jump to
>> the right point.  (I’ll make this change if no one objects.)
> 
> I have no objection.

Done on master.

> 
>> Merging the functions might only be worth doing if there were any more
>> places where \captionof needed to be used.
> 
> That's the intent, yes. It would be a waste not to use a package now
> residing in the default list. Among the transcoders where
> `org-latex--wrap-label' is used, some could probably benefit from
> a non-float caption, if requested by the user.

OK.  I’ll think about this.  One question is what type of caption this
should be.  (i.e. \captionof{what?}{the caption}).  Using the catch-all
figure caption type seems most sensible to me, but feedback from other
latex users is welcome.

Thanks,

-- 
Aaron Ecay