emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] org-clock: Fix CLOCK_INTO_DRAWER property check
Date: Thu, 16 Oct 2014 23:01:36 +0200

Kyle Meyer <address@hidden> writes:

> This new patch should handle that correctly.

Thanks.

>      (cond
> -     ((or (not (or p q)) (equal p "nil") (equal q "nil")) 
> org-clock-into-drawer)
> -     ((or (equal p "t") (equal q "t")) "LOGBOOK")
> -     ((not p) q)
> -     (t p))))
> +     ((not (or p q)) org-clock-into-drawer)
> +     ((equal p "nil") nil)
> +     ((equal p "t") "LOGBOOK")
> +     ((equal q "nil") nil)
> +     ((equal q "t") "LOGBOOK")
> +     (t (or p q)))))

Actually, it doesn't work either. Under some circumstances (e.g, when
p is a drawer name and q is "t"), q will have precedence over p, which
is not desirable.

What about this?

  (cond ((equal p "nil") nil)
        ((equal p "t") t)
        (p)
        ((equal q "nil") nil)
        ((equal q "t") t)
        (q)
        (t org-clock-into-drawer))


Regards,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]