Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

[Brice Waegenire]

Sorry for the long delayed response.
Here is that version of this patch, at least I hope it is.

Yes I signed the papers, my number is #1011602.

2015-05-07 22:09 GMT+02:00 Nicolas Goaziou <address@hidden>:
> Brice Waegenire <address@hidden> writes:
>
>> Thanks for help on this!
>> Here is the last version of the patch taking into account all of your
>> comments.
>
> Thank you.
>
>>                    (read-from-minibuffer
>> -                   "How many minutes left? "
>> -                   (if (not (eq org-timer-default-timer 0))
>> -                       (number-to-string org-timer-default-timer))))))
>> +                   "How much time left? (minutes or h:mm:ss) "
>> +                   (when (not (string-equal org-timer-default-timer "0"))
>
> Nitpick: `unless'
>
>> +                       (eval org-timer-default-timer))))))
>
> Since `org-timer-default-timer' is a string, there's no need to eval it.
>
> BTW, did you sign FSF papers already? If not, you need to add TINYCHANGE
> to the end of the commit message.
>
>
> Regards,

0001-org-timer.el-hh-mm-ss-format-for-setting-a-timer.patch
Description: Text Data