Re: [O] Unclear org-icompleting-read interface

[Nicolas Goaziou]

Hello,

Oleh Krehel <address@hidden> writes:

> The current `org-icompleting-read' is defined as taking only `&rest
> args', which can be as many as 8, all of them without a name.
>
> I propose to update the definition to:
>
>     (cl-defun org-icompleting-read (prompt collection
>                                     &key predicate require-match
>                                       initial-input hist def 
> inherit-input-method)
>       ;; ...
>       )

I'd rather not use cl-defun in code base, which is slightly more
difficult to understand, and hardly unavoidable. Moreover,
`org-icompleting-read' is not harder to read as `completing-read'
anyway.

> This change would make the calls to `org-icompleting-read' much easier
> to read.

While we're at it, I suggest instead to make `org-icompleting-read' an
obsolete alias for `completing-read' in Org 8.4.
`partial-completing-mode' is obsolete since Emacs 24.1.


Regards,

-- 
Nicolas Goaziou