[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack
|
From: |
Jan Malakhovski |
|
Subject: |
Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack |
|
Date: |
Wed, 04 Nov 2015 11:53:54 +0000 |
|
User-agent: |
Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.2 (x86_64-unknown-linux-gnu) |
Aaron Ecay <address@hidden> writes:
> Are you missing a close paren at the end of the above line?
It evaluates and works ok, so I think it's ok.
> Also, shouldn’t calc-eval take a string as an argument, not a lisp
> form? (I’m asking based on the docstring, I don’t know the calc API at
> all).
1) It was like this before.
2) It works.
3) calc-eval calls calc-do-calc-eval on this argument and the code
there does a dispatch on expression, so I think it's safe to assume
it's not actually a string (calc is a mess, yep).
- Re: [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere, (continued)
[O] [PATCH 7/9] org-notmuch: add date support to org-notmuch-store-link, Jan Malakhovski, 2015/11/03
[O] [PATCH 8/9] ob-calc: add more API, documentation and examples so that it can be used in tables, Jan Malakhovski, 2015/11/03
[O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/03
Re: [O] [PATCH v2 0/9] mail, clock and calc changes, Aaron Ecay, 2015/11/04