[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack
|
From: |
Aaron Ecay |
|
Subject: |
Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack |
|
Date: |
Wed, 04 Nov 2015 14:41:22 +0000 |
|
User-agent: |
Notmuch/0.20.2+65~gbd5504e (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) |
2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen:
>
> Aaron Ecay <address@hidden> writes:
>
>> Are you missing a close paren at the end of the above line?
>
> It evaluates and works ok, so I think it's ok.
Ok. Then:
1. The indentation is wrong, because (calc-pop 1) is the second argument
to calc-eval.
2. The prog1 form is not needed, because it only wraps a single form
(the calc-eval call).
This looks wrong to me, so please double-check.
--
Aaron Ecay
- [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props, (continued)
[O] [PATCH 7/9] org-notmuch: add date support to org-notmuch-store-link, Jan Malakhovski, 2015/11/03
[O] [PATCH 8/9] ob-calc: add more API, documentation and examples so that it can be used in tables, Jan Malakhovski, 2015/11/03
[O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/03
Re: [O] [PATCH v2 0/9] mail, clock and calc changes, Aaron Ecay, 2015/11/04