emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Substitute a guid XML element in org-feed


From: Hiroshi Saito
Subject: Re: [O] [PATCH] Substitute a guid XML element in org-feed
Date: Sat, 14 Nov 2015 13:15:32 +0900

Hi Nicolas,

Thank you for applying my patch.

I'm sorry to say the patch causes an error unless xml package is luckily
loaded. I attached another patch to fix it in my last post:
http://lists.gnu.org/archive/html/emacs-orgmode/2015-10/msg00417.html

Could you please review new patch or revert my first patch?

--
Sincerely,
Hiroshi Saito

2015-10-19 8:49 GMT+09:00 Hiroshi Saito <address@hidden>:
> Hi Michael,
>
> So sorry for that error. I did not notice.
>
> I wrote an additional patch to fix it. The patch makes sure that the xml
> library is loaded before calling `xml-substitute-special` as with
> `org-feed-parse-rss-entry` and `org-feed-parse-atom-feed`.
>
> --
> Sincerely,
> Hiroshi Saito
>
> 2015-10-19 2:54 GMT+09:00 Michael Brand <address@hidden>:
>> Hi Hiroshi
>>
>> On Sun, Sep 27, 2015 at 8:24 PM, Hiroshi Saito <address@hidden> wrote:
>>> A guid XML element is not substituted in org-feed. Here is a patch
>>> to fix it.
>>
>> It causes the error
>>
>>     if: Symbol's function definition is void: xml-substitute-special
>>
>> because xml is not loaded yet.
>>
>> Michael



reply via email to

[Prev in Thread] Current Thread [Next in Thread]