[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps
From: |
Gustav Wikström |
Subject: |
Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps |
Date: |
Thu, 26 Nov 2015 10:01:07 +0000 |
Hi,
> -----Original Message-----
> From: Nicolas Goaziou [mailto:address@hidden
> Sent: Thursday, November 26, 2015 09:22
> To: Gustav Wikström <address@hidden>
> Cc: sgeorgii . <address@hidden>; address@hidden
> Subject: Re: [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps
>
> Gustav Wikström <address@hidden> writes:
>
> > Taking your comments and improving the first patch a bit resulted in
> > the attached one. It replaces the previous. Using string-prefix-p and
> > string-suffix-p solves the out of index problem in the substrings.
Ok, darnit. And I see you found another workaround for that ;-)
>
> Applied. Thank you.
Great.
>
> I modified a bit the patch however, since my suggestion about using `string-
> suffix-p' doesn't hold: it isn't compatible with Emacs 24.3.
> I also removed a bunch of `setq'.
Ok, fair enough. A bit more difficult to follow the code now (in my opinion)
but I guess it saves a few I/O's.
There was a small error in your edit though. The push-statement feels lonely
outside of the let*.
>
>
> Regards,
Kind regards
Gustav
- [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, sgeorgii ., 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, sgeorgii ., 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, sgeorgii ., 2015/11/26
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/26
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps,
Gustav Wikström <=
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/26