[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-latex-compile timestamp checks
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] org-latex-compile timestamp checks |
Date: |
Sat, 16 Jan 2016 15:16:14 +0100 |
Hello,
Anthony Cowley <address@hidden> writes:
> * lisp/ox-latex.el (org-latex-compile): Improve timestamp check on HFS+
> filesystem by only considering 1-second clock resolution.
>
> Previously, the call to (current-time) could return a timestamp with
> a non-zero microsecond or picosecond fields, while the file attribute
> always has zeros for these fields. The check that the generated file is
> newer than the reference timestamp only succeeded when the time to
> generate the file crossed a 1-second clock interval.
>
> TINYCHANGE
> ---
> lisp/ox-latex.el | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index a57677b..f803b7e 100644
> --- a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -3576,7 +3576,8 @@ Return PDF file name or an error if it couldn't be
> produced."
> ;; Check for process failure. Provide collected errors if
> ;; possible.
> (if (or (not (file-exists-p pdffile))
> - (time-less-p (nth 5 (file-attributes pdffile)) time))
> + (time-less-p (subseq (nth 5 (file-attributes pdffile)) 0 2)
> + (subseq time 0 2)))
This sounds good. Thank you.
Although, I suggest to use `cl-subseq' instead of its alias. Also, it
may be worth commenting that trick right into the source.
Eventually, I think at least ox-texinfo.el, ox-man.el and ox-groff.el
need a similar trick.
Rasmus, what do you think?
Regards,
--
Nicolas Goaziou
- [O] [PATCH] org-latex-compile timestamp checks, Anthony Cowley, 2016/01/14
- Re: [O] [PATCH] org-latex-compile timestamp checks, Rasmus, 2016/01/15
- Re: [O] [PATCH] org-latex-compile timestamp checks, Anthony Cowley, 2016/01/15
- Re: [O] [PATCH] org-latex-compile timestamp checks,
Nicolas Goaziou <=
- Re: [O] [PATCH] org-latex-compile timestamp checks, Rasmus, 2016/01/16
- Re: [O] [PATCH] org-latex-compile timestamp checks, Anthony Cowley, 2016/01/16
- Re: [O] [PATCH] org-latex-compile timestamp checks, Nicolas Goaziou, 2016/01/21
- Re: [O] [PATCH] org-latex-compile timestamp checks, Rasmus, 2016/01/21
- Re: [O] [PATCH] org-latex-compile timestamp checks, Anthony Cowley, 2016/01/26
- Re: [O] [PATCH] org-latex-compile timestamp checks, Rasmus, 2016/01/26
- Re: [O] [PATCH] org-latex-compile timestamp checks, Nicolas Goaziou, 2016/01/26
- Re: [O] [PATCH] org-latex-compile timestamp checks, Rasmus, 2016/01/26
- Re: [O] [PATCH] org-latex-compile timestamp checks, Nicolas Goaziou, 2016/01/28
- Re: [O] [PATCH] org-latex-compile timestamp checks, Rasmus, 2016/01/28